-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declare the priority of options and environments on exporters #5379
Comments
XSAM
changed the title
Declare the priority of options and environments
Declare the priority of options and environments on exporters
May 18, 2024
MrAlias
added a commit
that referenced
this issue
Jun 18, 2024
…tlptracegrpc (#5508) part of #5379 --------- Co-authored-by: David Ashpole <[email protected]> Co-authored-by: Chester Cheung <[email protected]> Co-authored-by: Tyler Yahn <[email protected]>
OrHayat
pushed a commit
to OrHayat/opentelemetry-go
that referenced
this issue
Jun 23, 2024
…tlptracegrpc (open-telemetry#5508) part of open-telemetry#5379 --------- Co-authored-by: David Ashpole <[email protected]> Co-authored-by: Chester Cheung <[email protected]> Co-authored-by: Tyler Yahn <[email protected]>
OrHayat
pushed a commit
to OrHayat/opentelemetry-go
that referenced
this issue
Jun 23, 2024
…tlptracegrpc (open-telemetry#5508) part of open-telemetry#5379 --------- Co-authored-by: David Ashpole <[email protected]> Co-authored-by: Chester Cheung <[email protected]> Co-authored-by: Tyler Yahn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem Statement
Comments on options of exporters didn't specify the situation where both option and env are set. For instance,
opentelemetry-go/exporters/otlp/otlptrace/otlptracehttp/options.go
Lines 80 to 99 in 14441ae
This actually says when we apply both
OTEL_EXPORTER_OTLP_ENDPOINT
andOTEL_EXPORTER_OTLP_TRACES_ENDPOINT
at the same time,OTEL_EXPORTER_OTLP_TRACES_ENDPOINT
will take precedence.But this description is confusing, as it is after the sentence "If the OTEL_EXPORTER_OTLP_ENDPOINT or OTEL_EXPORTER_OTLP_TRACES_ENDPOINT environment variable is set, and this option is not passed, that variable value will be used.". Users might figure the env would take precedence when both the option and the env for the same feature are set.
Proposed Solution
Packages to check
The text was updated successfully, but these errors were encountered: