Skip to content

Commit

Permalink
Remove Min/Max unused interfaces from the moved code (#2454)
Browse files Browse the repository at this point in the history
Signed-off-by: Bogdan Drutu <[email protected]>

Co-authored-by: Tyler Yahn <[email protected]>
  • Loading branch information
bogdandrutu and MrAlias authored Dec 23, 2021
1 parent 4aedc1c commit 9778aa3
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 16 deletions.
15 changes: 11 additions & 4 deletions sdk/export/metric/aggregation/aggregation.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
package aggregation // import "go.opentelemetry.io/otel/sdk/export/metric/aggregation"

import (
"go.opentelemetry.io/otel/metric/number"
"go.opentelemetry.io/otel/sdk/metric/export/aggregation"
)

Expand All @@ -27,11 +28,17 @@ type Sum = aggregation.Sum
// Deprecated: use module "go.opentelemetry.io/otel/sdk/metric/export/aggregation"
type Count = aggregation.Count

// Deprecated: use module "go.opentelemetry.io/otel/sdk/metric/export/aggregation"
type Min = aggregation.Min
// Deprecated: Will be removed soon.
type Min interface {
Aggregation
Min() (number.Number, error)
}

// Deprecated: use module "go.opentelemetry.io/otel/sdk/metric/export/aggregation"
type Max = aggregation.Max
// Deprecated: Will be removed soon.
type Max interface {
Aggregation
Max() (number.Number, error)
}

// Deprecated: use module "go.opentelemetry.io/otel/sdk/metric/export/aggregation"
type LastValue = aggregation.LastValue
Expand Down
12 changes: 0 additions & 12 deletions sdk/metric/export/aggregation/aggregation.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,18 +46,6 @@ type (
Count() (uint64, error)
}

// Min returns the minimum value over the set of values that were aggregated.
Min interface {
Aggregation
Min() (number.Number, error)
}

// Max returns the maximum value over the set of values that were aggregated.
Max interface {
Aggregation
Max() (number.Number, error)
}

// LastValue returns the latest value that was aggregated.
LastValue interface {
Aggregation
Expand Down

0 comments on commit 9778aa3

Please sign in to comment.