Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade gRPC semconv from v1.24.0 to v1.26.0 #912

Merged
merged 15 commits into from
Jul 10, 2024

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jul 3, 2024

Replace net.peer.name with server.address.

Reference: changelog entry

@MrAlias MrAlias marked this pull request as ready for review July 3, 2024 20:03
@MrAlias MrAlias requested a review from a team July 3, 2024 20:03
@MrAlias MrAlias added this to the v0.14.0-alpha milestone Jul 3, 2024
Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MrAlias MrAlias merged commit b6e772d into open-telemetry:main Jul 10, 2024
18 checks passed
@MrAlias MrAlias deleted the grpc-semconv-v1.26.0 branch July 10, 2024 17:45
@MrAlias MrAlias mentioned this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants