Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HTTP client attributes #696

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Add HTTP client attributes #696

merged 4 commits into from
Feb 29, 2024

Conversation

RonFed
Copy link
Contributor

@RonFed RonFed commented Feb 28, 2024 •
edited
Loading

Adding:

  • server.address
  • server.port
  • network.protocol.version

These are consistent with the latest semantic conventions

@RonFed RonFed marked this pull request as ready for review February 28, 2024 15:13
@RonFed RonFed requested a review from a team February 28, 2024 15:13
@edeNFed edeNFed merged commit 93aa6b8 into open-telemetry:main Feb 29, 2024
17 checks passed
@damemi damemi mentioned this pull request Mar 26, 2024
Merged
@MrAlias MrAlias added this to the v0.11.0-alpha milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edeNFed edeNFed edeNFed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.11.0-alpha
Development

Successfully merging this pull request may close these issues.
3 participants
@RonFed @edeNFed @MrAlias