feat(otelglobal): add support for Span SetName #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asecondo
force-pushed
the
542-manual-instrumentation-set-name
branch
4 times, most recently
from
e95e8a2
to
ec328e2
Compare
asecondo
changed the title
asecondo
force-pushed
the
542-manual-instrumentation-set-name
branch
2 times, most recently
from
b8e3135
to
539c2a5
Compare
asecondo
changed the title
RonFed
reviewed
Jan 10, 2024
internal/pkg/instrumentation/bpf/go.opentelemetry.io/otel/traceglobal/bpf/probe.bpf.c
Outdated
Show resolved
Hide resolved
internal/pkg/instrumentation/bpf/go.opentelemetry.io/otel/traceglobal/bpf/probe.bpf.c
Outdated
Show resolved
Hide resolved
asecondo
force-pushed
the
542-manual-instrumentation-set-name
branch
from
daa9268
to
0860a84
Compare
asecondo
force-pushed
the
542-manual-instrumentation-set-name
branch
from
0860a84
to
3c8c55f
Compare
asecondo
changed the title
MikeGoldsmith
approved these changes
Jan 12, 2024
internal/pkg/instrumentation/bpf/go.opentelemetry.io/otel/traceglobal/bpf/probe.bpf.c
Outdated
Show resolved
Hide resolved
MrAlias
approved these changes
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for setting a span name via manual instrumentation, as described in #542.
NOTE: this is my first PR in this repo. Open to any and all suggestions 🙂