Add WithResourceAttributes option
#522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
reviewed
Nov 21, 2023
pellared
reviewed
Nov 21, 2023
Co-authored-by: Robert Pająk <[email protected]>
Co-authored-by: Robert Pająk <[email protected]>
edeNFed
changed the title
WithAdditionalResourceAttributes optionWithResourceAttributes option
RonFed
approved these changes
Nov 22, 2023
pellared
reviewed
Nov 22, 2023
Co-authored-by: Robert Pająk <[email protected]>
pellared
reviewed
Nov 22, 2023
There was a problem hiding this comment.
Outside of @pellared's suggestions, I think this looks good.
Have you done any testing of how this works alongside the SDK picking up resource attributes from the OTEL_RESOURCE_ATTRIBUTES environment variable? I believe it should be fine as the two sets of attributes will be merged as part of the resource.NewWithAttributes call.
|
Thanks @MikeGoldsmith I added some more test cases |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
WithAdditionalResourceAttributeswhich allows users to pass additional resource attributes that should be reported by the instrumentation