Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix database instrumentation for Go < 1.17 #1772

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Feb 7, 2025

Use the correct context argument position in the UPROBE_RETURN macro.

Fix #1581

Tested locally: #1581 (comment)

Use the correct context argument position in the UPROBE_RETURN macro.
@MrAlias MrAlias marked this pull request as ready for review February 7, 2025 19:30
@MrAlias MrAlias requested a review from a team as a code owner February 7, 2025 19:30
@MrAlias MrAlias added the bug Something isn't working label Feb 7, 2025
@MrAlias MrAlias added this to the v0.21.0 milestone Feb 7, 2025
@MrAlias MrAlias merged commit f1dabe8 into open-telemetry:main Feb 7, 2025
28 checks passed
@MrAlias MrAlias deleted the fix-1581 branch February 7, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The ctx position in return probe might be incorrect
2 participants