Skip to content

envcar: normalize cached environment variable names#8761

Merged
dmathieu merged 4 commits intoopen-telemetry:mainfrom
pellared:envcar-normalize-cache
Apr 3, 2026
Merged

envcar: normalize cached environment variable names#8761
dmathieu merged 4 commits intoopen-telemetry:mainfrom
pellared:envcar-normalize-cache

Conversation

@pellared
Copy link
Copy Markdown
Member

@pellared pellared commented Apr 2, 2026

Per open-telemetry/opentelemetry-java#8233 (comment)

This is specification compliant and I think even more than the current implementation given: https://github.com/open-telemetry/opentelemetry-specification/blob/778b565b1e68ef612227d2874fc3a641fadcbfeb/specification/context/env-carriers.md?plain=1#L61-L65

It also follows the robustness principle as e.g. non-normalized traceparent env var can still be used by the propagation getter.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.2%. Comparing base (ad990b6) to head (8b266ad).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #8761   +/-   ##
=====================================
  Coverage   82.2%   82.2%           
=====================================
  Files        183     183           
  Lines      13919   13920    +1     
=====================================
+ Hits       11444   11456   +12     
+ Misses      2067    2056   -11     
  Partials     408     408           
Files with missing lines Coverage Δ
propagators/envcar/carrier.go 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pellared pellared marked this pull request as ready for review April 2, 2026 18:40
@pellared pellared requested a review from a team as a code owner April 2, 2026 18:40
@github-actions github-actions Bot requested a review from Joibel April 2, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants