envcar: refine normalization#8678
Merged
Merged
Conversation
Member
Author
|
@Joibel PTAL |
MrAlias
approved these changes
Mar 13, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8678 +/- ##
=====================================
Coverage 82.0% 82.1%
=====================================
Files 182 183 +1
Lines 13780 13790 +10
=====================================
+ Hits 11311 11332 +21
+ Misses 2065 2054 -11
Partials 404 404
🚀 New features to boost your workflow:
|
dmathieu
approved these changes
Mar 13, 2026
kamphaus
approved these changes
Mar 14, 2026
github-merge-queue Bot
pushed a commit
to open-telemetry/opentelemetry-specification
that referenced
this pull request
Mar 18, 2026
…rmalization rules (#4944) This PR aligns environment variable context propagation naming with POSIX.1-2024 and defines normalization rules for propagation keys. Fixes #4914 Prototype open-telemetry/opentelemetry-go-contrib#8678 Note that the changes are in a document which has status "Alpha". ## Motivation The current text refers to platform-specific restrictions but does not define how invalid propagation keys should be handled. In particular, it does not clearly address cases such as: - names containing `-` (which is used e.g. by https://github.com/openzipkin/b3-propagation) or other disallowed characters - names beginning with digits ## Changes Propagation keys MUST be normalized to valid environment variable names by: - converting ASCII letters to uppercase - replacing disallowed characters with `_` - prefixing `_` when the name would otherwise begin with a digit ## Benefits - Defines deterministic behavior across SDKs - Improves interoperability between propagators (e.g., W3C and B3) - Reduces implementation ambiguity - Aligns with POSIX.1-2024 --------- Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
From POSIX Standards:
Related to open-telemetry/opentelemetry-specification#4914
What
Change the normalization so that it adds
_in front when the key starts with a digit so that the result is compliant with the POSIX Standards.