otelconf: support service resource detector#8674
Merged
dmathieu merged 7 commits intoMar 17, 2026
Merged
Conversation
This relies on the unreleased feature in the go SDK `WithService`. Not sure if it's ok to update the go.mod to use main or if we wait until the next release. Signed-off-by: alex boten <223565+codeboten@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8674 +/- ##
=====================================
Coverage 82.1% 82.1%
=====================================
Files 183 183
Lines 13790 13792 +2
=====================================
+ Hits 11332 11334 +2
Misses 2054 2054
Partials 404 404
🚀 New features to boost your workflow:
|
dashpole
approved these changes
Mar 13, 2026
Contributor
dashpole
left a comment
There was a problem hiding this comment.
I'm OK with updating to a commit. We will do the update to the released version of the SDK prior to the contrib release anyways
Signed-off-by: alex boten <223565+codeboten@users.noreply.github.com>
dmathieu
approved these changes
Mar 13, 2026
flc1125
approved these changes
Mar 16, 2026
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relies on the unreleased feature in the go SDK
WithService. Not sure if it's ok to update the go.mod to use main or if we wait until the next release.