Skip to content

otelconf: support service resource detector#8674

Merged
dmathieu merged 7 commits into
open-telemetry:mainfrom
codeboten:codeboten/add-support-for-service-resource-detector
Mar 17, 2026
Merged

otelconf: support service resource detector#8674
dmathieu merged 7 commits into
open-telemetry:mainfrom
codeboten:codeboten/add-support-for-service-resource-detector

Conversation

@codeboten
Copy link
Copy Markdown
Contributor

This relies on the unreleased feature in the go SDK WithService. Not sure if it's ok to update the go.mod to use main or if we wait until the next release.

This relies on the unreleased feature in the go SDK `WithService`. Not sure if it's ok to update the go.mod to use main or if we wait until the next release.

Signed-off-by: alex boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten requested review from a team and pellared as code owners March 12, 2026 20:24
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.1%. Comparing base (fbcde6f) to head (2dcc8a8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #8674   +/-   ##
=====================================
  Coverage   82.1%   82.1%           
=====================================
  Files        183     183           
  Lines      13790   13792    +2     
=====================================
+ Hits       11332   11334    +2     
  Misses      2054    2054           
  Partials     404     404           
Files with missing lines Coverage Δ
otelconf/resource.go 100.0% <100.0%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmathieu dmathieu added this to the v1.43.0 milestone Mar 13, 2026
Copy link
Copy Markdown
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with updating to a commit. We will do the update to the released version of the SDK prior to the contrib release anyways

Signed-off-by: alex boten <223565+codeboten@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants