Skip to content

Limit the number of bytes read from the zpages body #8656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmathieu merged 3 commits into from
Mar 10, 2026
Merged

Limit the number of bytes read from the zpages body #8656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f8aa048
limit the number of bytes read from the zpages body
dmathieu Mar 9, 2026
c9ef2c7
add changelog entry
dmathieu Mar 9, 2026
513bf60
Merge branch 'main' into zpages-max-body
dmathieu Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

## [Unreleased]

### Fixed

- Limit the request body size at 1MB in `go.opentelemetry.io/contrib/zpages`. (#8656)

<!-- Released section -->
<!-- Don't change this section unless doing release -->

Expand Down
4 changes: 4 additions & 0 deletions zpages/tracez.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ const (
spanLatencyBucketQueryField = "zlatencybucket"
// maxTraceMessageLength is the maximum length of a message in tracez output.
maxTraceMessageLength = 1024

maxRequestBodySize = 1 << 20 // 1MB
)

type summaryTableData struct {
Expand Down Expand Up @@ -79,6 +81,8 @@ func NewTracezHandler(sp *SpanProcessor) http.Handler {
// ServeHTTP implements the http.Handler and is capable of serving "tracez" HTTP requests.
func (th *tracezHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "text/html; charset=utf-8")

r.Body = http.MaxBytesReader(w, r.Body, maxRequestBodySize)
if err := r.ParseForm(); err != nil {
w.WriteHeader(http.StatusBadRequest)
return
Expand Down
Loading