feat(net/http/otelhttp): Add http.route attribute

[gaiaz-iusipov]

Fixes #8633

In this pull request, I add recording of the http.route metric attribute for net/http/otelhttp.

This PR does not affect any instrumentation other than otelhttp, because the check if route == "" && req.Pattern != "" is triggered only in otelhttp.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.2%. Comparing base (7d66e8f) to head (b84e6d0).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##            main   #8632     +/-   ##
=======================================
- Coverage   82.2%   82.2%   -0.1%     
=======================================
  Files        183     183             
  Lines      13907   13919     +12     
=======================================
+ Hits       11443   11444      +1     
- Misses      2056    2067     +11     
  Partials     408     408             

Files with missing lines	Coverage Δ
.../go-restful/otelrestful/internal/semconv/server.go	83.2% <100.0%> (+0.1%)	⬆️
...m/gin-gonic/gin/otelgin/internal/semconv/server.go	83.2% <100.0%> (+0.1%)	⬆️
...com/gorilla/mux/otelmux/internal/semconv/server.go	83.2% <100.0%> (+0.1%)	⬆️
.../labstack/echo/otelecho/internal/semconv/server.go	83.2% <100.0%> (+0.1%)	⬆️
...httptrace/otelhttptrace/internal/semconv/server.go	83.2% <100.0%> (+0.1%)	⬆️
...ation/net/http/otelhttp/internal/semconv/server.go	83.2% <100.0%> (+0.1%)	⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[pellared]

Can you please create an issue first?

From https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CONTRIBUTING.md#contributing-code:

It's recommended that you signal your intention to contribute in the issue tracker, either by filing a new issue or by claiming an existing one.

[dmathieu]

Could this be done with a Labeler?

[gaiaz-iusipov]

I created an issue where I tried to explain my motivation: #8633

[gaiaz-iusipov]

I changed the logic so that the attribute is recorded by default, with an option to disable it. There is also still the question of moving the routeFromRequest function to the semconv package. Let’s discuss the final approach in the issue.

[gaiaz-iusipov]

Could this be done with a Labeler?

Sure it could, but @pellared pointed out in the issue that this attribute should always (when it is available) be recorded by default.

[dmathieu]

Sure, though this is not what that PR was doing when I left my comment.
Now: the attribute can be removed with a view. Why do we need the option?

[gaiaz-iusipov]

Sure, though this is not what that PR was doing when I left my comment. Now: the attribute can be removed with a view. Why do we need the option?

So it turns out the option is not needed at all. What about moving the routeFromRequest function to semconv.HTTPServer and making it public since its logic is duplicated?

[flc1125]

Some small adjustments.

[gaiaz-iusipov]

I think this PR is ready to merge.

[dmathieu]

I'm waiting for @pellared's review, since he requested changes.

Issue has been created and I added it to the PR description.

[pellared]

It looks that the description in #8633 is not updated

I also do not follow the following part of the current PR description

The routeFromRequest function code is duplicated, and it might be better to move it to semconv.HTTPServer.

Can you please update the issue and PR description?

[gaiaz-iusipov]

Can you please update the issue and PR description?

@pellared thanks for the review, I will update the issue description and this PR.