Skip to content

otelconf: use translation strategy instead of deprecated funcs#8595

Merged
pellared merged 5 commits intoopen-telemetry:mainfrom
codeboten:codeboten/translation-strategy
Mar 2, 2026
Merged

otelconf: use translation strategy instead of deprecated funcs#8595
pellared merged 5 commits intoopen-telemetry:mainfrom
codeboten:codeboten/translation-strategy

Conversation

@codeboten
Copy link
Copy Markdown
Contributor

This fixes an issue in the otelconf package that was preventing the Collector from upgrading to the latest version of the library. The issue is that the prometheus exporter uses a translation strategy that could not be changed with the existing configuration options, and this changed the output from the exporter, breaking backwards compat for the collector when upgrading to otelconf v0.20.0. See open-telemetry/opentelemetry-collector#14602 (review) for more details.

This fixes an issue in the otelconf package that was preventing the Collector from upgrading to the latest version of the library. The issue is that the prometheus exporter uses a translation strategy that could not be changed with the existing configuration options, and this changed the output from the exporter, breaking backwards compat for the collector when upgrading to otelconf v0.20.0. See open-telemetry/opentelemetry-collector#14602 (review) for more details.

Signed-off-by: alex boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten requested review from a team and pellared as code owners February 24, 2026 21:59
Signed-off-by: alex boten <223565+codeboten@users.noreply.github.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 24, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.1%. Comparing base (d2a5807) to head (e8ed446).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
otelconf/v0.2.0/metric.go 50.0% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #8595     +/-   ##
=======================================
- Coverage   82.1%   82.1%   -0.1%     
=======================================
  Files        179     179             
  Lines      13662   13662             
=======================================
- Hits       11229   11227      -2     
- Misses      2032    2033      +1     
- Partials     401     402      +1     
Files with missing lines Coverage Δ
otelconf/v0.3.0/metric.go 89.7% <100.0%> (ø)
otelconf/v0.2.0/metric.go 88.9% <50.0%> (-0.7%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread otelconf/v0.2.0/metric.go
@codeboten
Copy link
Copy Markdown
Contributor Author

I dont think the lint check failure is related to changes in this pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants