Skip to content

otelhttp: Deprecate WithMetricAttributesFn in favor of Labeler #8587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pellared merged 6 commits into from
Mar 2, 2026
+7 −0
Merged

otelhttp: Deprecate WithMetricAttributesFn in favor of Labeler #8587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5f57965
otelhttp: Deprecate WithMetricAttributesFn in favor of Labeler
sonalgaud12 Feb 22, 2026
381008f
Update CHANGELOG.md
dmathieu Mar 2, 2026
fa4ffd5
Update instrumentation/net/http/otelhttp/config.go
dmathieu Mar 2, 2026
d38a831
Merge branch 'main' into labeler
dmathieu Mar 2, 2026
c4ac4e2
Merge branch 'main' into labeler
dmathieu Mar 2, 2026
1a6b204
Merge branch 'main' into labeler
pellared Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ The next release will require at least [Go 1.25].

- Updated the configuration schema used in `go.opentelemetry.io/contrib/otelconf` to [rc.3](https://github.com/open-telemetry/opentelemetry-configuration/releases/tag/v1.0.0-rc.3). (#8505)

### Deprecated

- `WithMetricAttributesFn` in `go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp` is deprecated and will be removed in a future release. Use `Labeler` instead. (#8587)

<!-- Released section -->
<!-- Don't change this section unless doing release -->

Expand Down
3 changes: 3 additions & 0 deletions instrumentation/net/http/otelhttp/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,9 @@ func WithServerName(server string) Option {

// WithMetricAttributesFn returns an Option to set a function that maps an HTTP request to a slice of attribute.KeyValue.
// These attributes will be included in metrics for every request.
//
// Deprecated: WithMetricAttributesFn is deprecated and will be removed in a
// future release. Use [Labeler] instead.
func WithMetricAttributesFn(metricAttributesFn func(r *http.Request) []attribute.KeyValue) Option {
return optionFunc(func(c *config) {
c.MetricAttributesFn = metricAttributesFn
Expand Down
Loading