Skip to content

otelconf: remove host ID detector in host configuration#8581

Merged
dmathieu merged 5 commits intoopen-telemetry:mainfrom
codeboten:codeboten/remove-host-id
Mar 12, 2026
Merged

otelconf: remove host ID detector in host configuration#8581
dmathieu merged 5 commits intoopen-telemetry:mainfrom
codeboten:codeboten/remove-host-id

Conversation

@codeboten
Copy link
Copy Markdown
Contributor

The host ID detector returns an error in a containerized environment. My suggestion with this PR is to remove it. An option here, would be to update the WithHost detector to include the host ID as well, and return a partial error, which the configuration package could check for. Maybe someone who is more familar with the resource detectors and their implementations could chime in here. I suppose we could also add another option WithHostAndHostID or something like it, but that seems redundant.

The host ID detector returns an error in a containerized environment. My suggestion with this PR is to remove it. An option here, would be to update the `WithHost` detector to include the host ID as well, and return a partial error, which the configuration package could check for. Maybe someone who is more familar with the resource detectors and their implementations could chime in here. I suppose we could also add another option WithHostAndHostID or something like it, but that seems redundant.

Signed-off-by: alex boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten requested review from a team and pellared as code owners February 19, 2026 18:08
Comment thread CHANGELOG.md Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.1%. Comparing base (69316a1) to head (3d319c2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #8581   +/-   ##
=====================================
  Coverage   82.1%   82.1%           
=====================================
  Files        182     182           
  Lines      13780   13780           
=====================================
  Hits       11322   11322           
  Misses      2054    2054           
  Partials     404     404           
Files with missing lines Coverage Δ
otelconf/resource.go 100.0% <100.0%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: alex boten <223565+codeboten@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants