otelconf: remove host ID detector in host configuration#8581
Merged
dmathieu merged 5 commits intoopen-telemetry:mainfrom Mar 12, 2026
Merged
otelconf: remove host ID detector in host configuration#8581dmathieu merged 5 commits intoopen-telemetry:mainfrom
dmathieu merged 5 commits intoopen-telemetry:mainfrom
Conversation
The host ID detector returns an error in a containerized environment. My suggestion with this PR is to remove it. An option here, would be to update the `WithHost` detector to include the host ID as well, and return a partial error, which the configuration package could check for. Maybe someone who is more familar with the resource detectors and their implementations could chime in here. I suppose we could also add another option WithHostAndHostID or something like it, but that seems redundant. Signed-off-by: alex boten <223565+codeboten@users.noreply.github.com>
codeboten
commented
Feb 19, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8581 +/- ##
=====================================
Coverage 82.1% 82.1%
=====================================
Files 182 182
Lines 13780 13780
=====================================
Hits 11322 11322
Misses 2054 2054
Partials 404 404
🚀 New features to boost your workflow:
|
Signed-off-by: alex boten <223565+codeboten@users.noreply.github.com>
dmathieu
approved these changes
Mar 11, 2026
flc1125
approved these changes
Mar 12, 2026
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The host ID detector returns an error in a containerized environment. My suggestion with this PR is to remove it. An option here, would be to update the
WithHostdetector to include the host ID as well, and return a partial error, which the configuration package could check for. Maybe someone who is more familar with the resource detectors and their implementations could chime in here. I suppose we could also add another option WithHostAndHostID or something like it, but that seems redundant.