google.golang.org/grpc/otelgrpc: Fix for elapsedTime records an incorrect metric value#8509
Merged
dmathieu merged 9 commits intoopen-telemetry:mainfrom Feb 10, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8509 +/- ##
=====================================
Coverage 82.2% 82.2%
=====================================
Files 179 179
Lines 13700 13700
=====================================
Hits 11265 11265
Misses 2033 2033
Partials 402 402
🚀 New features to boost your workflow:
|
Member
|
Please keep your changes atomic (a single thing per PR). |
Contributor
Author
|
I will remove from this PR the changes that are not related to the gRPC tooling. |
Member
|
For the record, this dates to #4548, before the stabilization of RPC attributes, and when the duration attribute was actually ms. |
dmathieu
reviewed
Feb 5, 2026
Co-authored-by: Damien Mathieu <42@dmathieu.com>
dmathieu
approved these changes
Feb 6, 2026
dashpole
approved these changes
Feb 9, 2026
MrAlias
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
elapsedTimebeing recorded as (ms * 1000) ingoogle.golang.org/grpc/otelgrpc. For example, a value of 5ms is written as 5s instead of 0.005s.Fix #8518