Fix zpages CSS and JS CDN URLs#8502
Merged
Merged
Conversation
Signed-off-by: pradhyum6144 <pradhyum314@gmail.com>
Signed-off-by: pradhyum6144 <pradhyum314@gmail.com>
Contributor
Author
|
Hello @dashpole sir, can review this if there is any changes need mention i will change or please review and merge it . |
Contributor
Author
Thank you sir for assigning this issue can you please merge it. If there are any issues please assign me i am ready to work. |
Contributor
|
This requires a second review. |
dashpole
reviewed
Feb 3, 2026
MrAlias
reviewed
Feb 3, 2026
MrAlias
approved these changes
Feb 3, 2026
Contributor
MrAlias
left a comment
There was a problem hiding this comment.
LGTM outside of the changelog entry needed fix.
Signed-off-by: pradhyum6144 <pradhyum314@gmail.com>
Contributor
|
@pradhyum6144 the only requirement this PR still needs to satisfy is to remain open for a full day. Thanks for the contribution. |
dmathieu
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8470
Problem
The zpages module references Material Design Lite CSS and JavaScript from
code.getmdl.io, which is currently returning 403 Forbidden errors, breaking the zpages UI.Solution
Replaced the broken CDN with
cdnjs.cloudflare.com, which is actively maintained and accessible.Changes
zpages/internal/templates/header.htmlto use cdnjs.cloudflare.com CDN URLsTesting
go test -race ./zpages/...Verification