Skip to content

otelconf: validate client key/cert symmetry for mTLS#8450

Merged
MrAlias merged 5 commits intoopen-telemetry:mainfrom
sandy2008:main
Feb 3, 2026
Merged

otelconf: validate client key/cert symmetry for mTLS#8450
MrAlias merged 5 commits intoopen-telemetry:mainfrom
sandy2008:main

Conversation

@sandy2008
Copy link
Copy Markdown
Member

Summary

  • Error when a client key is provided without a client certificate in TLS config.
  • Add a unit test for the client-key-only case.

Testing

  • go build ./...

@sandy2008 sandy2008 requested review from a team and pellared as code owners January 22, 2026 15:02
@github-actions github-actions Bot requested a review from codeboten January 22, 2026 15:02
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.2%. Comparing base (32b20e5) to head (acc3d51).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #8450   +/-   ##
=====================================
  Coverage   82.1%   82.2%           
=====================================
  Files        179     179           
  Lines      13690   13692    +2     
=====================================
+ Hits       11244   11257   +13     
+ Misses      2044    2033   -11     
  Partials     402     402           
Files with missing lines Coverage Δ
otelconf/internal/tls/config.go 85.0% <100.0%> (+1.6%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sandy2008
Copy link
Copy Markdown
Member Author

@dmathieu Thank you! Do you know when we can get it merged?

@dmathieu
Copy link
Copy Markdown
Member

When we have a second approval.

@sandy2008
Copy link
Copy Markdown
Member Author

@pellared @codeboten Could you help take a look :)? Thank you!!

Copy link
Copy Markdown
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@MrAlias MrAlias merged commit 82cfc18 into open-telemetry:main Feb 3, 2026
38 of 45 checks passed
@MrAlias MrAlias added this to the v1.41.0 milestone Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants