Skip to content

Add version file for prometheus bridge#8401

Merged
dmathieu merged 3 commits into
open-telemetry:mainfrom
eddyariki:fix/version-const-prometheus
Jan 16, 2026
Merged

Add version file for prometheus bridge#8401
dmathieu merged 3 commits into
open-telemetry:mainfrom
eddyariki:fix/version-const-prometheus

Conversation

@eddyariki
Copy link
Copy Markdown
Contributor

Adds version.go for bridges/prometheus.

Part of #8272

Up for discussions

Should I include changes to bridges/prometheus/producer.go and bridges/prometheus/producer_test.go in this PR? Or should it be separated?

@eddyariki eddyariki requested review from a team and dashpole as code owners January 15, 2026 11:46
@eddyariki eddyariki marked this pull request as draft January 15, 2026 11:47
@eddyariki eddyariki marked this pull request as ready for review January 15, 2026 11:49
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.3%. Comparing base (0e6a3d2) to head (2d2d0a5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #8401   +/-   ##
=====================================
  Coverage   82.3%   82.3%           
=====================================
  Files        179     179           
  Lines      13728   13728           
=====================================
  Hits       11307   11307           
  Misses      2023    2023           
  Partials     398     398           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmathieu dmathieu merged commit a09dfba into open-telemetry:main Jan 16, 2026
28 checks passed
Copy link
Copy Markdown
Member

@flc1125 flc1125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be even better if a version number were added here.

Scope: instrumentation.Scope{
Name: scopeName,
},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants