Skip to content

Switch version from function to string in host#8358

Merged
dmathieu merged 3 commits into
open-telemetry:mainfrom
jongwooo:switch-versions-from-functions-to-strings-in-host
Jan 8, 2026
Merged

Switch version from function to string in host#8358
dmathieu merged 3 commits into
open-telemetry:mainfrom
jongwooo:switch-versions-from-functions-to-strings-in-host

Conversation

@jongwooo
Copy link
Copy Markdown
Member

@jongwooo jongwooo commented Jan 7, 2026

Change Version() func to const Version string in host

Part of #8272

@jongwooo jongwooo requested review from a team and dmathieu as code owners January 7, 2026 06:08
@dmathieu
Copy link
Copy Markdown
Member

dmathieu commented Jan 7, 2026

This needs a changelog entry.

Signed-off-by: Jongwoo Han <jongwooo.han@gmail.com>
@jongwooo jongwooo force-pushed the switch-versions-from-functions-to-strings-in-host branch from 07f4ed5 to 7129359 Compare January 7, 2026 08:26
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.3%. Comparing base (c303460) to head (62d9e33).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #8358     +/-   ##
=======================================
- Coverage   82.3%   82.3%   -0.1%     
=======================================
  Files        188     187      -1     
  Lines      13769   13767      -2     
=======================================
- Hits       11334   11332      -2     
  Misses      2030    2030             
  Partials     405     405             
Files with missing lines Coverage Δ
instrumentation/host/host.go 78.5% <100.0%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmathieu dmathieu merged commit 36b1431 into open-telemetry:main Jan 8, 2026
41 of 45 checks passed
@jongwooo jongwooo deleted the switch-versions-from-functions-to-strings-in-host branch January 8, 2026 15:34
@MrAlias MrAlias added this to the v1.40.0 milestone Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants