Skip to content

Switch version from function to string in otellambda#8357

Merged
dmathieu merged 3 commits into
open-telemetry:mainfrom
jongwooo:switch-versions-from-functions-to-strings-in-otellambda
Jan 8, 2026
Merged

Switch version from function to string in otellambda#8357
dmathieu merged 3 commits into
open-telemetry:mainfrom
jongwooo:switch-versions-from-functions-to-strings-in-otellambda

Conversation

@jongwooo
Copy link
Copy Markdown
Member

@jongwooo jongwooo commented Jan 7, 2026

Change Version() func to const Version string in otellambda, otellambda/xrayconfig

Part of #8272

@jongwooo jongwooo requested a review from a team as a code owner January 7, 2026 06:05
@github-actions github-actions Bot requested a review from akats7 January 7, 2026 06:05
@dmathieu
Copy link
Copy Markdown
Member

dmathieu commented Jan 7, 2026

This needs a changelog entry.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.2%. Comparing base (991be59) to head (5b2cdd3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #8357     +/-   ##
=======================================
- Coverage   82.3%   82.2%   -0.1%     
=======================================
  Files        189     188      -1     
  Lines      13771   13769      -2     
=======================================
- Hits       11336   11323     -13     
- Misses      2030    2041     +11     
  Partials     405     405             
Files with missing lines Coverage Δ
.../github.com/aws/aws-lambda-go/otellambda/lambda.go 90.2% <100.0%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Jongwoo Han <jongwooo.han@gmail.com>
@jongwooo jongwooo force-pushed the switch-versions-from-functions-to-strings-in-otellambda branch from c3e2bdc to 7382a34 Compare January 7, 2026 08:25
@dmathieu
Copy link
Copy Markdown
Member

dmathieu commented Jan 7, 2026

Please avoid force-pushing PRs. That breaks the GitHub review workflow.

Comment thread CHANGELOG.md Outdated
@dmathieu dmathieu merged commit c303460 into open-telemetry:main Jan 8, 2026
28 checks passed
@jongwooo jongwooo deleted the switch-versions-from-functions-to-strings-in-otellambda branch January 8, 2026 15:34
@MrAlias MrAlias added this to the v1.40.0 milestone Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants