Skip to content

Switch version from function to string in otelaws#8356

Merged
dmathieu merged 4 commits into
open-telemetry:mainfrom
jongwooo:switch-versions-from-functions-to-strings-in-otelaws
Jan 8, 2026
Merged

Switch version from function to string in otelaws#8356
dmathieu merged 4 commits into
open-telemetry:mainfrom
jongwooo:switch-versions-from-functions-to-strings-in-otelaws

Conversation

@jongwooo
Copy link
Copy Markdown
Member

@jongwooo jongwooo commented Jan 7, 2026

Change Version() func to const Version string in otelaws

Part of #8272

@jongwooo jongwooo requested a review from a team as a code owner January 7, 2026 05:56
@github-actions github-actions Bot requested a review from akats7 January 7, 2026 05:56
@dmathieu
Copy link
Copy Markdown
Member

dmathieu commented Jan 7, 2026

This needs a changelog entry.

Signed-off-by: Jongwoo Han <jongwooo.han@gmail.com>
@jongwooo jongwooo force-pushed the switch-versions-from-functions-to-strings-in-otelaws branch from e11ab99 to 3e23fca Compare January 7, 2026 08:23
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.3%. Comparing base (bdd9e3a) to head (8a57641).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #8356     +/-   ##
=======================================
- Coverage   82.3%   82.3%   -0.1%     
=======================================
  Files        190     189      -1     
  Lines      13773   13771      -2     
=======================================
- Hits       11338   11336      -2     
  Misses      2030    2030             
  Partials     405     405             
Files with missing lines Coverage Δ
...tation/github.com/aws/aws-sdk-go-v2/otelaws/aws.go 97.5% <100.0%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmathieu dmathieu merged commit 991be59 into open-telemetry:main Jan 8, 2026
28 checks passed
@jongwooo jongwooo deleted the switch-versions-from-functions-to-strings-in-otelaws branch January 8, 2026 15:34
@MrAlias MrAlias added this to the v1.40.0 milestone Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants