Skip to content

refactor(otelgin): switch version from function to string#8341

Merged
dmathieu merged 8 commits into
open-telemetry:mainfrom
ElenaZvereva:8272-otelgin
Jan 13, 2026
Merged

refactor(otelgin): switch version from function to string#8341
dmathieu merged 8 commits into
open-telemetry:mainfrom
ElenaZvereva:8272-otelgin

Conversation

@ElenaZvereva
Copy link
Copy Markdown
Contributor

Change Version() func to const Version string in otelgin
Part of #8272

@ElenaZvereva ElenaZvereva requested review from a team and flc1125 as code owners December 29, 2025 14:45
@github-actions github-actions Bot requested a review from akats7 December 29, 2025 14:45
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 30, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.3%. Comparing base (6e187c4) to head (2f875e9).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...umentation/github.com/gin-gonic/gin/otelgin/gin.go 66.6% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #8341     +/-   ##
=======================================
- Coverage   82.3%   82.3%   -0.1%     
=======================================
  Files        182     181      -1     
  Lines      13764   13762      -2     
=======================================
- Hits       11329   11327      -2     
  Misses      2030    2030             
  Partials     405     405             
Files with missing lines Coverage Δ
...umentation/github.com/gin-gonic/gin/otelgin/gin.go 92.9% <66.6%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Internal comments should not be visible in pkg.go.dev.

Comment thread instrumentation/github.com/gin-gonic/gin/otelgin/version.go Outdated
@ElenaZvereva ElenaZvereva requested a review from pellared January 7, 2026 18:36
@dmathieu dmathieu dismissed pellared’s stale review January 13, 2026 09:10

Requested changes have been applied.

@dmathieu dmathieu merged commit 748e224 into open-telemetry:main Jan 13, 2026
27 of 28 checks passed
@MrAlias MrAlias added this to the v1.40.0 milestone Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants