fix(otelgrpc): prevent panic when nil TracerProvider or MeterProvider is passed#8323
Merged
dmathieu merged 2 commits intoJan 6, 2026
Merged
Conversation
Contributor
Author
Contributor
Author
flc1125
approved these changes
Dec 20, 2025
Member
|
Perhaps we need to add a CHANGELOG. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8323 +/- ##
=====================================
Coverage 82.3% 82.3%
=====================================
Files 192 192
Lines 13767 13767
=====================================
Hits 11332 11332
Misses 2030 2030
Partials 405 405
🚀 New features to boost your workflow:
|
8bbd4ef to
8a74ff1
Compare
… is passed Commit 07504e4 removed nil checks from WithTracerProvider and WithMeterProvider, causing a panic when callers pass nil. This restores the checks so nil values are ignored and the global provider is used. Signed-off-by: Davanum Srinivas <davanum@gmail.com>
8a74ff1 to
723c047
Compare
dmathieu
approved these changes
Jan 5, 2026
dashpole
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 07504e4 removed nil checks from WithTracerProvider and WithMeterProvider, causing a panic when callers pass nil. This restores the checks so nil values are ignored and the global provider is used.
This showed up in some future-proof-ci jobs in kubernetes:
https://storage.googleapis.com/kubernetes-ci-logs/logs/ci-kubernetes-unit-dependencies/2002001097211777024/build-log.txt