Skip to content

Switch version from function to string in otelgrpc#8317

Merged
dmathieu merged 11 commits into
open-telemetry:mainfrom
ElenaZvereva:8272-otelgrpc
Jan 14, 2026
Merged

Switch version from function to string in otelgrpc#8317
dmathieu merged 11 commits into
open-telemetry:mainfrom
ElenaZvereva:8272-otelgrpc

Conversation

@ElenaZvereva
Copy link
Copy Markdown
Contributor

refactor(otelgrpc): change Version() func to const Version string
Part of #8272

@ElenaZvereva ElenaZvereva requested review from a team and dashpole as code owners December 19, 2025 10:35
Comment thread CHANGELOG.md Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.3%. Comparing base (1139186) to head (03188f1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #8317     +/-   ##
=======================================
- Coverage   82.3%   82.3%   -0.1%     
=======================================
  Files        179     178      -1     
  Lines      13695   13693      -2     
=======================================
- Hits       11274   11272      -2     
  Misses      2023    2023             
  Partials     398     398             
Files with missing lines Coverage Δ
...n/google.golang.org/grpc/otelgrpc/stats_handler.go 98.5% <100.0%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ElenaZvereva ElenaZvereva requested a review from flc1125 December 25, 2025 14:52
Comment thread instrumentation/google.golang.org/grpc/otelgrpc/version.go Outdated
ElenaZvereva and others added 2 commits January 7, 2026 20:28
Co-authored-by: Robert Pająk <pellared@hotmail.com>
@ElenaZvereva ElenaZvereva requested a review from pellared January 7, 2026 18:36
Comment thread CHANGELOG.md Outdated
@ElenaZvereva ElenaZvereva requested a review from dmathieu January 8, 2026 13:28
Comment thread CHANGELOG.md Outdated
@ElenaZvereva ElenaZvereva requested a review from dmathieu January 8, 2026 13:38
@flc1125
Copy link
Copy Markdown
Member

flc1125 commented Jan 14, 2026

@ElenaZvereva Please fix the conflict in the CHANGELOG

@dmathieu dmathieu dismissed pellared’s stale review January 14, 2026 08:47

The requested changes have been applied.

@dmathieu dmathieu merged commit 18da5d8 into open-telemetry:main Jan 14, 2026
28 checks passed
@MrAlias MrAlias added this to the v1.40.0 milestone Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants