Skip to content

Switch version from function to string in otelhttptrace#8302

Merged
dmathieu merged 14 commits into
open-telemetry:mainfrom
ElenaZvereva:8272-httptrace
Jan 12, 2026
Merged

Switch version from function to string in otelhttptrace#8302
dmathieu merged 14 commits into
open-telemetry:mainfrom
ElenaZvereva:8272-httptrace

Conversation

@ElenaZvereva
Copy link
Copy Markdown
Contributor

refactor(otelhttptrace): change Version() func to const Version string
Part of #8272

@ElenaZvereva ElenaZvereva requested review from a team and dmathieu as code owners December 17, 2025 21:03
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Dec 17, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: dmathieu / name: Damien Mathieu (e55f183)

Comment thread CHANGELOG.md Outdated
Comment thread instrumentation/net/http/httptrace/otelhttptrace/version.go Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.3%. Comparing base (324aed7) to head (e55f183).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #8302     +/-   ##
=======================================
- Coverage   82.3%   82.3%   -0.1%     
=======================================
  Files        183     182      -1     
  Lines      13766   13764      -2     
=======================================
- Hits       11331   11329      -2     
  Misses      2030    2030             
  Partials     405     405             
Files with missing lines Coverage Δ
...on/net/http/httptrace/otelhttptrace/clienttrace.go 83.7% <100.0%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ElenaZvereva and others added 3 commits December 18, 2025 12:26
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Copy link
Copy Markdown
Member

@flc1125 flc1125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only this change.

Comment thread CHANGELOG.md Outdated
Comment thread instrumentation/net/http/httptrace/otelhttptrace/version.go Outdated
ElenaZvereva and others added 2 commits January 7, 2026 20:23
@ElenaZvereva ElenaZvereva requested a review from pellared January 7, 2026 18:36
@ElenaZvereva
Copy link
Copy Markdown
Contributor Author

@dmathieu should I re-request review of the whole team after every change in PR? Or should I only wait for approval from the person who suggested the last change (in this case - @pellared)?

@dmathieu
Copy link
Copy Markdown
Member

No need to rerequest review from everyone.

@dmathieu dmathieu dismissed pellared’s stale review January 12, 2026 14:17

Requested changes have been applied.

@dmathieu
Copy link
Copy Markdown
Member

The changes requested by @pellared were applied over 5 days ago, and this has 2 reviews. Merging.

@dmathieu dmathieu merged commit 69c031c into open-telemetry:main Jan 12, 2026
28 checks passed
@MrAlias MrAlias added this to the v1.40.0 milestone Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants