Remove the deprecated WithPublicEndpoint from otelhttp#8267
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8267 +/- ##
=======================================
- Coverage 82.3% 82.3% -0.1%
=======================================
Files 193 193
Lines 13780 13778 -2
=======================================
- Hits 11345 11343 -2
Misses 2030 2030
Partials 405 405
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated WithPublicEndpoint function from the otelhttp instrumentation package, completing the deprecation cycle that was introduced in version 1.39.0. The function was a convenience wrapper that always returned true, and users should migrate to the more flexible WithPublicEndpointFn which allows conditional configuration based on the request.
- Removed the deprecated
WithPublicEndpointfunction fromconfig.go - Removed the associated test
TestWithPublicEndpointfromhandler_test.go - Updated CHANGELOG.md to document the removal with migration guidance
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| instrumentation/net/http/otelhttp/config.go | Removed the deprecated WithPublicEndpoint function and its documentation |
| instrumentation/net/http/otelhttp/handler_test.go | Removed TestWithPublicEndpoint test; functionality is covered by TestWithPublicEndpointFn |
| CHANGELOG.md | Added removal entry under "Unreleased" section with migration guidance |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.