otelhttp: export Event type for WithMessageEvents#8153
Merged
Conversation
Contributor
Author
|
Hello @dmathieu , OpenTelemetry Go enums usually prefix constants with the type name (e.g. SpanKindServer, SpanKindClient). So shall I change |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8153 +/- ##
=====================================
Coverage 82.1% 82.1%
=====================================
Files 195 195
Lines 13680 13680
=====================================
+ Hits 11243 11244 +1
+ Misses 2031 2029 -2
- Partials 406 407 +1
🚀 New features to boost your workflow:
|
flc1125
reviewed
Nov 10, 2025
33a327d to
ae43cdd
Compare
dmathieu
reviewed
Nov 10, 2025
flc1125
reviewed
Nov 10, 2025
flc1125
reviewed
Nov 10, 2025
Member
|
@sonalgaud12 Please fix the lint; we can use |
dmathieu
approved these changes
Nov 18, 2025
flc1125
reviewed
Nov 18, 2025
Member
|
Could you solve the lint issue please? |
Merge branch 'otelhttp' of https://github.com/sonalgaud12/opentelemetry-go-contrib into otelhttp
dmathieu
approved these changes
Dec 1, 2025
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Contributor
Author
|
Hey @flc1125 , Can you please review this? |
flc1125
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #8132
The WithMessageEvents option previously accepted an unexported type (event).
This change exports the type as Event.