otelhttp: deprecate the WithRouteTag option#8117
Merged
Merged
Conversation
dashpole
approved these changes
Nov 3, 2025
MrAlias
approved these changes
Nov 3, 2025
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8117 +/- ##
=====================================
Coverage 80.9% 81.0%
=====================================
Files 194 194
Lines 13073 13073
=====================================
+ Hits 10588 10592 +4
+ Misses 2107 2105 -2
+ Partials 378 376 -2
🚀 New features to boost your workflow:
|
pellared
reviewed
Nov 8, 2025
| // with HTTP route attribute. | ||
| // | ||
| // Deprecated: spans are automatically annotated with the route attribute. | ||
| // To annotate metrics, use the `WithMetricAttributesFn` option. |
Member
There was a problem hiding this comment.
This should be
Suggested change
| // To annotate metrics, use the `WithMetricAttributesFn` option. | |
| // To annotate metrics, use the [WithMetricAttributesFn] option. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of #8107
The
WithRouteTagoption doesn't really have any needs anymore.For spans, we already add the route name automatically. For metrics, folks can use the
WithMetricAttributesFnoption.