otelconf: add unmarshaling and validation for span & cardinality limits#8043
Merged
MrAlias merged 11 commits intoOct 23, 2025
Merged
Conversation
Adds unmarshaler code for SpanLimits and CardinalityLimits which require validation to ensure fields are set following the boundaries set by the schema. Signed-off-by: alex boten <223565+codeboten@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8043 +/- ##
=======================================
+ Coverage 79.6% 79.7% +0.1%
=======================================
Files 187 190 +3
Lines 11833 11912 +79
=======================================
+ Hits 9420 9495 +75
- Misses 2059 2062 +3
- Partials 354 355 +1
🚀 New features to boost your workflow:
|
Signed-off-by: alex boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: alex boten <223565+codeboten@users.noreply.github.com>
dmathieu
reviewed
Oct 21, 2025
Member
dmathieu
left a comment
There was a problem hiding this comment.
This looks good. But it seems it should have a changelog entry.
Signed-off-by: alex boten <223565+codeboten@users.noreply.github.com>
Contributor
Author
changelog added |
Contributor
Author
|
/easycla |
dmathieu
approved these changes
Oct 22, 2025
MrAlias
reviewed
Oct 22, 2025
Signed-off-by: alex boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: alex boten <223565+codeboten@users.noreply.github.com>
MrAlias
approved these changes
Oct 23, 2025
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds unmarshaler code for SpanLimits and CardinalityLimits which require validation to ensure fields are set following the boundaries set by the schema.
Part of breaking up #8026