feat(mongo): add SpanNameResolver for customizable span naming#7986
Merged
dmathieu merged 34 commits intoNov 5, 2025
Conversation
Azer0s
force-pushed
the
feat/mongo-span-name-resolver
branch
4 times, most recently
from
fc23cbf to
0dd6c01
Compare
dmathieu
reviewed
Oct 7, 2025
Azer0s
force-pushed
the
feat/mongo-span-name-resolver
branch
from
0dd6c01 to
e528e47
Compare
Azer0s
force-pushed
the
feat/mongo-span-name-resolver
branch
from
e528e47 to
807588d
Compare
Member
|
This will need a changelog entry. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7986 +/- ##
=====================================
Coverage 80.9% 81.0%
=====================================
Files 194 194
Lines 13073 13081 +8
=====================================
+ Hits 10588 10596 +8
Misses 2107 2107
Partials 378 378
🚀 New features to boost your workflow:
|
Contributor
Author
I added one |
dmathieu
approved these changes
Oct 7, 2025
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Azer0s
force-pushed
the
feat/mongo-span-name-resolver
branch
2 times, most recently
from
8c36929 to
8a811ee
Compare
Azer0s
force-pushed
the
feat/mongo-span-name-resolver
branch
from
df66b8e to
ac9e992
Compare
Contributor
Author
|
@dmathieu could you please merge? :) |
Member
|
We require 2 approvals to merge. |
Contributor
Author
|
Ping @prestonvasquez :) |
flc1125
reviewed
Oct 9, 2025
…nto feat/mongo-span-name-resolver # Conflicts: # instrumentation/go.mongodb.org/mongo-driver/v2/mongo/otelmongo/go.mod # instrumentation/go.mongodb.org/mongo-driver/v2/mongo/otelmongo/go.sum
…nto feat/mongo-span-name-resolver
Co-authored-by: Preston Vasquez <prestonvasquez@icloud.com>
Co-authored-by: Preston Vasquez <prestonvasquez@icloud.com>
Co-authored-by: Preston Vasquez <prestonvasquez@icloud.com>
dmathieu
reviewed
Nov 5, 2025
dmathieu
reviewed
Nov 5, 2025
dmathieu
approved these changes
Nov 5, 2025
Contributor
Author
|
@dmathieu the pipeline is currently failing (as far as I can see, nothing I broke) and I don't have the permission to merge or restart the pipeline. Could you do that please? :) |
Contributor
Author
|
@dmathieu I think we're ready to merge! 🥳 |
Member
|
We require 2 approvals to merge. |
Contributor
Author
|
@prestonvasquez could you approve? |
flc1125
reviewed
Nov 5, 2025
| if collection, err := extractCollection(evt); err == nil && collection != "" { | ||
| spanName = collection + "." | ||
|
|
||
| collection, err := extractCollection(evt) |
Member
There was a problem hiding this comment.
In fact, when using the default SpanNameFormatter, we executed the extractCollection method twice. Is there a better way?
Secondly, it seems that users cannot access the collection information. Unless it implements a similar logic itself.
Member
There was a problem hiding this comment.
See #7986 (comment)
That helper method should be made available by the mongo SDK, not by us.
prestonvasquez
approved these changes
Nov 5, 2025
Member
prestonvasquez
left a comment
prestonvasquez
left a comment
There was a problem hiding this comment.
LGTM, thanks @Azer0s 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a SpanNameResolver function to the monitor options in order to customize the span name to the users needs. This is especially relevant when dealing with multiple database instances, having to prefix spans, or generally needing to customize the span name.