otelmux: Adding http.route attribute to metrics

[vinayvennela]

Changes Made in the PR:

1. Re-use the "route" attribute thats captured during span creation in the metric attributes
2. Test covering the metric attribute "http.route" is present
3. Fixed existing unit test that has incorrect metric names and added changes to fail the test when such changes happen in future.

Implements - #7954

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: vinayvennela / name: Vinay Vennela (488d98d, 171c34b, 6ba273d, 4c85578, ca03559, 526ca02, 5075156, c301545, 4e5be9b, 8f1af5e)

[akats7]

Hi @vinayvennela, please sign the cla and add a change log entry as this is a user facing change

[vinayvennela]

Hi @vinayvennela, please sign the cla and add a change log entry as this is a user facing change

Signed and added the CL

[dmathieu]

Running CI so you see the failures. But your changes won't work. The semconv package is generated (as is mentioned at the top of each file).
You need to update the template in https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/internal/shared/semconv, and to run make generate.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.6%. Comparing base (ca22ed4) to head (4e5be9b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #7966   +/-   ##
=====================================
  Coverage   78.5%   78.6%           
=====================================
  Files        184     184           
  Lines      14636   14673   +37     
=====================================
+ Hits       11496   11533   +37     
  Misses      2789    2789           
  Partials     351     351           

Files with missing lines	Coverage Δ
.../go-restful/otelrestful/internal/semconv/server.go	82.0% <100.0%> (+0.4%)	⬆️
...m/gin-gonic/gin/otelgin/internal/semconv/server.go	82.0% <100.0%> (+0.4%)	⬆️
...com/gorilla/mux/otelmux/internal/semconv/server.go	82.0% <100.0%> (+0.4%)	⬆️
...trumentation/github.com/gorilla/mux/otelmux/mux.go	97.9% <100.0%> (+<0.1%)	⬆️
.../labstack/echo/otelecho/internal/semconv/server.go	82.0% <100.0%> (+0.4%)	⬆️
...httptrace/otelhttptrace/internal/semconv/server.go	82.0% <100.0%> (+0.4%)	⬆️
...ation/net/http/otelhttp/internal/semconv/server.go	82.0% <100.0%> (+0.4%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[vinayvennela]

Running CI so you see the failures. But your changes won't work. The semconv package is generated (as is mentioned at the top of each file). You need to update the template in https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/internal/shared/semconv, and to run make generate.

It really didn't strike my mind at all. Again thanks for being patient with me in explaining it.

[vinayvennela]

Hey @dmathieu , do you know when is the next release planned that contains this feature?

[dmathieu]

It should be in the coming weeks.

[flc1125]

Hey @dmathieu , do you know when is the next release planned that contains this feature?

If you need to use it urgently, you can use go get -u go.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmux@main to use the unreleased version.