Deprecate the go.opentelemetry.io/contrib/detectors/aws/ec2 module#7725
Merged
MrAlias merged 3 commits intoopen-telemetry:mainfrom Aug 13, 2025
Merged
Conversation
pellared
reviewed
Aug 12, 2025
Member
There was a problem hiding this comment.
The package needs to also be deprecated.
Currently the PR only deprecates the module.
See: https://go.dev/wiki/Deprecated
Signed-off-by: carsontham <carsontham@outlook.com>
carsontham
force-pushed
the
deprecate-detectors-aws-ec2
branch
from
6a4644d to
1db1d19
Compare
Member
Author
|
hi @pellared, i have also deprecated the module, could you take a look? thanks ! |
MrAlias
reviewed
Aug 13, 2025
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
MrAlias
approved these changes
Aug 13, 2025
akats7
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecate the go.opentelemetry.io/contrib/detectors/aws/ec2 module and added changelog.
Resolves #7684