Skip to content

Fix deprecation of Extract/Inject in otelgrpc#7689

Merged
pellared merged 7 commits intoopen-telemetry:mainfrom
nithinputhenveettil:fix/otelgrpc-Inject-Extract-deprecation
Aug 8, 2025
Merged

Fix deprecation of Extract/Inject in otelgrpc#7689
pellared merged 7 commits intoopen-telemetry:mainfrom
nithinputhenveettil:fix/otelgrpc-Inject-Extract-deprecation

Conversation

@nithinputhenveettil
Copy link
Copy Markdown
Contributor

Fixes #7687

I tried running it locally using go run golang.org/x/pkgsite/cmd/pkgsite@latest -open in local, and everything looks fine to me.

image

@nithinputhenveettil nithinputhenveettil requested review from a team and dashpole as code owners August 7, 2025 19:27
@nithinputhenveettil
Copy link
Copy Markdown
Contributor Author

@MrAlias : Since this deprecation was originally added 3 years ago, I’m not sure if it still needs to go in the CHANGELOG. What do you all think? I can add it if everyone feels it's necessary.

@MrAlias
Copy link
Copy Markdown
Contributor

MrAlias commented Aug 7, 2025

@MrAlias : Since this deprecation was originally added 3 years ago, I’m not sure if it still needs to go in the CHANGELOG. What do you all think? I can add it if everyone feels it's necessary.

+1 to adding an entry in the changelog under a ### Deprecated header in ## Unreleased.

It looks like the original included an entry, but it was not in the correct section header and we should try to announce it as much as possible now that tools are going to flag the functions.

@nithinputhenveettil
Copy link
Copy Markdown
Contributor Author

@MrAlias: Agreed, I’ve added the entry to the CHANGELOG under the correct section.

Comment thread CHANGELOG.md Outdated
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.8%. Comparing base (b06b2a8) to head (673be11).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #7689   +/-   ##
=====================================
  Coverage   78.7%   78.8%           
=====================================
  Files        186     186           
  Lines      14705   14705           
=====================================
+ Hits       11585   11591    +6     
+ Misses      2780    2776    -4     
+ Partials     340     338    -2     
Files with missing lines Coverage Δ
...ogle.golang.org/grpc/otelgrpc/metadata_supplier.go 58.1% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pellared pellared merged commit e97180b into open-telemetry:main Aug 8, 2025
28 checks passed
@nithinputhenveettil nithinputhenveettil deleted the fix/otelgrpc-Inject-Extract-deprecation branch August 8, 2025 14:58
@MrAlias MrAlias added this to the v1.38.0 milestone Aug 20, 2025
@MrAlias MrAlias mentioned this pull request Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix deprecation of Extract/Inject in otelgrpc

5 participants