Skip to content

feat(otelecho): add HTTP server metrics support for echo instrumentation#7668

Merged
dmathieu merged 7 commits intoopen-telemetry:mainfrom
Whitea029:feat_echo_metrics
Aug 26, 2025
Merged

feat(otelecho): add HTTP server metrics support for echo instrumentation#7668
dmathieu merged 7 commits intoopen-telemetry:mainfrom
Whitea029:feat_echo_metrics

Conversation

@Whitea029
Copy link
Copy Markdown
Contributor

Description:

  • Implement otelecho.WithServerMetrics() option to enable HTTP server metrics
  • Add comprehensive test coverage for metrics functionality

Related Issue:

fix #7656

@Whitea029 Whitea029 requested a review from a team as a code owner August 5, 2025 16:04
@github-actions github-actions Bot requested a review from scorpionknifes August 5, 2025 16:04
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.0%. Comparing base (6b59b27) to head (ee240d6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #7668   +/-   ##
=====================================
  Coverage   78.9%   79.0%           
=====================================
  Files        186     186           
  Lines      14823   14871   +48     
=====================================
+ Hits       11703   11751   +48     
  Misses      2780    2780           
  Partials     340     340           
Files with missing lines Coverage Δ
...tation/github.com/labstack/echo/otelecho/config.go 100.0% <100.0%> (ø)
...entation/github.com/labstack/echo/otelecho/echo.go 100.0% <100.0%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@flc1125
Copy link
Copy Markdown
Member

flc1125 commented Aug 6, 2025

Please fix the lint and also add a CHANGELOG.

@flc1125 flc1125 changed the title feat(otelecho):support http server metrics for echo instrumentation feat(otelecho): add HTTP server metrics support for echo instrumentation Aug 6, 2025
@flc1125
Copy link
Copy Markdown
Member

flc1125 commented Aug 6, 2025

Please fix the lint and also add a CHANGELOG.

We can perform lint checks using make lint, and run unit tests with make test.

Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
@Whitea029 Whitea029 requested a review from flc1125 August 6, 2025 01:38
@Whitea029 Whitea029 requested a review from flc1125 August 6, 2025 03:33
@dmathieu dmathieu merged commit 01f6306 into open-telemetry:main Aug 26, 2025
34 checks passed
@MrAlias MrAlias added this to the v1.38.0 milestone Aug 28, 2025
@MrAlias MrAlias mentioned this pull request Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[otel-echo] Expose stable HTTP server metrics in Echo instrumentation

5 participants