Updated ECS detector containerID logic#7607
Merged
dmathieu merged 5 commits intoopen-telemetry:mainfrom Jul 28, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7607 +/- ##
======================================
Coverage ? 78.7%
======================================
Files ? 186
Lines ? 14818
Branches ? 0
======================================
Hits ? 11672
Misses ? 2798
Partials ? 348
🚀 New features to boost your workflow:
|
dmathieu
reviewed
Jul 22, 2025
pellared
reviewed
Jul 23, 2025
dmathieu
approved these changes
Jul 24, 2025
flc1125
requested changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the ECS detector to properly extract the containerID from cgroup file.
Resolves #7500
Failing tests in
opentelemetry-go-contrib/detectors/aws/ecs/test/ecs_test.gowere due to incorrect logic pertaining to cgroup paths on valid ecs containers vs other non empty valuesAdded tests for extracting containerIDs from various cgroup path values