otellambda: allow custom attributes#7556
Merged
Merged
Conversation
Contributor
Author
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7556 +/- ##
=====================================
Coverage 78.7% 78.7%
=====================================
Files 186 186
Lines 14807 14816 +9
=====================================
+ Hits 11656 11665 +9
Misses 2803 2803
Partials 348 348
🚀 New features to boost your workflow:
|
dmathieu
reviewed
Jul 8, 2025
Contributor
|
Thanks for your interest in the project. Please provide a complete enhancement issue in #7557 prior to proposing a change here. Design and motivation can be discussed there. |
Member
|
@akats7 what do you think of this, as code owner? |
akats7
reviewed
Jul 21, 2025
Contributor
|
This is a good update, definitely seems valuable |
akats7
approved these changes
Jul 23, 2025
dmathieu
approved these changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new feature to the AWS Lambda OpenTelemetry Go instrumentation, allowing users to attach custom attributes to spans based on the Lambda event payload. This enhancement provides greater flexibility for enriching traces with application-specific context.
Changes
New Option: WithTraceAttributeFn
Instrumentation Logic Update
Unit Tests