Skip to content

otelconf/v0.3.0: add support for provider options#7552

Merged
dmathieu merged 3 commits into
open-telemetry:mainfrom
axw:otelconf-provideroptions
Jul 8, 2025
Merged

otelconf/v0.3.0: add support for provider options#7552
dmathieu merged 3 commits into
open-telemetry:mainfrom
axw:otelconf-provideroptions

Conversation

@axw
Copy link
Copy Markdown
Contributor

@axw axw commented Jul 7, 2025

Fixes #7549

Support users passing {Logger,Meter,Tracer}ProviderOptions into NewSDK. These options will be combined with configuration file-based options; the latter will take precedence.

@axw axw force-pushed the otelconf-provideroptions branch from 83a8c25 to b3ee8bb Compare July 7, 2025 01:55
@github-actions github-actions Bot requested review from codeboten and pellared July 7, 2025 01:55
Support users passing {Logger,Meter,Tracer}ProviderOptions
into NewSDK. These options will be combined with configuration
file-based options; the latter will take precedence.
@axw axw force-pushed the otelconf-provideroptions branch from b3ee8bb to 5012c8b Compare July 7, 2025 01:57
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.5%. Comparing base (e0a9d09) to head (935de3e).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #7552   +/-   ##
=====================================
  Coverage   81.5%   81.5%           
=====================================
  Files        198     198           
  Lines      17963   17976   +13     
=====================================
+ Hits       14647   14663   +16     
+ Misses      2917    2916    -1     
+ Partials     399     397    -2     
Files with missing lines Coverage Δ
otelconf/v0.3.0/config.go 92.1% <100.0%> (+1.3%) ⬆️
otelconf/v0.3.0/log.go 97.4% <100.0%> (+1.8%) ⬆️
otelconf/v0.3.0/metric.go 89.3% <100.0%> (-0.1%) ⬇️
otelconf/v0.3.0/trace.go 99.5% <100.0%> (-0.1%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@axw
Copy link
Copy Markdown
Contributor Author

axw commented Jul 7, 2025

I have only updated v0.3.0, please let me know if you would like v0.2.0 to be updated too.

@axw axw marked this pull request as ready for review July 7, 2025 02:11
@axw axw requested a review from a team as a code owner July 7, 2025 02:11
Comment thread CHANGELOG.md Outdated
Comment thread otelconf/v0.3.0/config.go
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Copy link
Copy Markdown
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@codeboten, PTAL

Copy link
Copy Markdown
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @axw! Looks great

@dmathieu dmathieu merged commit b72e8bc into open-telemetry:main Jul 8, 2025
29 checks passed
@axw axw deleted the otelconf-provideroptions branch July 8, 2025 07:14
@MrAlias MrAlias added this to the v1.38.0 milestone Jul 17, 2025
@MrAlias MrAlias mentioned this pull request Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

otelconf: enable passing in provider options

5 participants