update mux default span name to include http method#7551
Merged
MrAlias merged 17 commits intoopen-telemetry:mainfrom Aug 4, 2025
Merged
update mux default span name to include http method#7551MrAlias merged 17 commits intoopen-telemetry:mainfrom
MrAlias merged 17 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7551 +/- ##
=====================================
Coverage 78.7% 78.7%
=====================================
Files 186 186
Lines 14694 14701 +7
=====================================
+ Hits 11571 11581 +10
+ Misses 2782 2780 -2
+ Partials 341 340 -1
🚀 New features to boost your workflow:
|
dmathieu
reviewed
Jul 7, 2025
dmathieu
reviewed
Jul 8, 2025
dmathieu
approved these changes
Jul 21, 2025
Contributor
Author
|
@open-telemetry/go-approvers Can I please get another review |
flc1125
approved these changes
Jul 25, 2025
Member
|
Can you handle the conflict in the |
MrAlias
reviewed
Jul 30, 2025
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
MrAlias
reviewed
Aug 3, 2025
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Contributor
|
Looks like the
|
Contributor
|
Bumping the CI. |
MrAlias
reviewed
Aug 4, 2025
MrAlias
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the default span name for the mux instrumentation to include the http method to align to the semconvs.
Added a test for default span naming and attributes