Skip to content

update mux default span name to include http method#7551

Merged
MrAlias merged 17 commits intoopen-telemetry:mainfrom
akats7:mux-spanname
Aug 4, 2025
Merged

update mux default span name to include http method#7551
MrAlias merged 17 commits intoopen-telemetry:mainfrom
akats7:mux-spanname

Conversation

@akats7
Copy link
Copy Markdown
Contributor

@akats7 akats7 commented Jul 7, 2025

Updates the default span name for the mux instrumentation to include the http method to align to the semconvs.

Added a test for default span naming and attributes

@akats7 akats7 requested a review from a team as a code owner July 7, 2025 01:20
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.7%. Comparing base (3ba7b7d) to head (a2ff5f2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #7551   +/-   ##
=====================================
  Coverage   78.7%   78.7%           
=====================================
  Files        186     186           
  Lines      14694   14701    +7     
=====================================
+ Hits       11571   11581   +10     
+ Misses      2782    2780    -2     
+ Partials     341     340    -1     
Files with missing lines Coverage Δ
...trumentation/github.com/gorilla/mux/otelmux/mux.go 97.9% <100.0%> (+2.2%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread CHANGELOG.md Outdated
Comment thread instrumentation/github.com/gorilla/mux/otelmux/mux.go Outdated
Copy link
Copy Markdown
Member

@dmathieu dmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice.

Comment thread instrumentation/github.com/gorilla/mux/otelmux/mux.go Outdated
@akats7
Copy link
Copy Markdown
Contributor Author

akats7 commented Jul 24, 2025

@open-telemetry/go-approvers Can I please get another review

@flc1125
Copy link
Copy Markdown
Member

flc1125 commented Jul 25, 2025

Can you handle the conflict in the CHANGELOG

Comment thread instrumentation/github.com/gorilla/mux/otelmux/mux.go Outdated
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Comment thread instrumentation/github.com/gorilla/mux/otelmux/mux.go Outdated
Comment thread instrumentation/github.com/gorilla/mux/otelmux/mux.go Outdated
Comment thread CHANGELOG.md Outdated
akats7 and others added 3 commits August 3, 2025 15:39
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@MrAlias
Copy link
Copy Markdown
Contributor

MrAlias commented Aug 4, 2025

Looks like the slices import needs to be removed as it is no longer used:

Error: ./mux.go:9:2: "slices" imported and not used (typecheck)

@MrAlias
Copy link
Copy Markdown
Contributor

MrAlias commented Aug 4, 2025

Bumping the CI.

@MrAlias MrAlias closed this Aug 4, 2025
@MrAlias MrAlias reopened this Aug 4, 2025
Comment thread CHANGELOG.md Outdated
@MrAlias MrAlias merged commit 420e00b into open-telemetry:main Aug 4, 2025
29 checks passed
@MrAlias MrAlias added this to the v1.38.0 milestone Aug 20, 2025
@MrAlias MrAlias mentioned this pull request Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants