Skip to content

fix: Stop EKS detector erroring outside of K8S#7483

Merged
dmathieu merged 4 commits intoopen-telemetry:mainfrom
bodgit:issue7477
Jun 20, 2025
Merged

fix: Stop EKS detector erroring outside of K8S#7483
dmathieu merged 4 commits intoopen-telemetry:mainfrom
bodgit:issue7477

Conversation

@bodgit
Copy link
Copy Markdown
Contributor

@bodgit bodgit commented Jun 18, 2025

This is a simple fix to stop the EKS detector erroring when run outside of Kubernetes.

Fixes #7477

@bodgit bodgit requested a review from a team as a code owner June 18, 2025 00:02
@dashpole
Copy link
Copy Markdown
Contributor

Can you add a unit test?

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.5%. Comparing base (be730df) to head (a36b6e8).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #7483   +/-   ##
=====================================
  Coverage   81.5%   81.5%           
=====================================
  Files        198     198           
  Lines      17961   17963    +2     
=====================================
+ Hits       14643   14647    +4     
+ Misses      2918    2917    -1     
+ Partials     400     399    -1     
Files with missing lines Coverage Δ
detectors/aws/eks/detector.go 39.3% <100.0%> (+3.6%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmathieu dmathieu merged commit 0bd4ab3 into open-telemetry:main Jun 20, 2025
28 checks passed
@pellared pellared added this to the v1.37.0 milestone Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EKS detector errors outside of EKS/K8S

4 participants