[DO NOT MERGE] minsev: Fix to filter out only in SeverityTrace1..SeverityFatal4 severity range#7424
Closed
pellared wants to merge 6 commits intoopen-telemetry:mainfrom
Closed
[DO NOT MERGE] minsev: Fix to filter out only in SeverityTrace1..SeverityFatal4 severity range#7424pellared wants to merge 6 commits intoopen-telemetry:mainfrom
pellared wants to merge 6 commits intoopen-telemetry:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7424 +/- ##
=====================================
Coverage 82.2% 82.2%
=====================================
Files 205 205
Lines 17949 17952 +3
=====================================
+ Hits 14768 14774 +6
+ Misses 2743 2741 -2
+ Partials 438 437 -1
🚀 New features to boost your workflow:
|
dmathieu
approved these changes
Jun 4, 2025
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Member
Author
|
Marking as blocked by specification as I do not want us to go back and forth until: and maybe are resolved. |
Member
Author
|
From the SIG meetings discussions it seems that most prefer our current implementation: open-telemetry/opentelemetry-specification#4541 (comment). I will extract the Go docs improvements to a separate PR. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per open-telemetry/opentelemetry-specification#4541
From https://github.com/open-telemetry/opentelemetry-specification/blob/bdcf53d55285ae42339f37908a24ba6f3ac167cb/specification/logs/data-model.md?plain=1#L418-L423:
Currently the spec only describes how to compare values between 1 and 24.
All other values have undefined meaning.
The main reason is to NOT filter out records with
log.SeverityUndefinedseverity which can be a common scenario.I also did my best to improve the docs.