add option for public endpoint to gRPC#7407
Merged
dmathieu merged 7 commits intoopen-telemetry:mainfrom Jun 5, 2025
Merged
Conversation
dashpole
reviewed
May 30, 2025
Contributor
dashpole
left a comment
There was a problem hiding this comment.
looks good. Just needs unit tests for config and for the handler
Contributor
Author
|
hey, thank you for the fast response. I added tests, I based them on the |
5c47ffa to
4e191c3
Compare
dashpole
approved these changes
May 30, 2025
4e191c3 to
382c644
Compare
dmathieu
reviewed
Jun 2, 2025
644d5c4 to
f16cccf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7407 +/- ##
=====================================
Coverage 82.2% 82.3%
=====================================
Files 205 205
Lines 17949 17967 +18
=====================================
+ Hits 14768 14795 +27
+ Misses 2743 2735 -8
+ Partials 438 437 -1
🚀 New features to boost your workflow:
|
dmathieu
reviewed
Jun 2, 2025
dmathieu
approved these changes
Jun 2, 2025
Co-authored-by: Damien Mathieu <42@dmathieu.com>
6704b75 to
bafe9f4
Compare
Member
|
Please don't rebase your branch every time. Merge commits make our reviews much easier. |
Contributor
Author
|
sorry for the many rebases, I only wanted to fix the merge conflict with main. I hope I didn't complicate things for the PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #7406
This adds the option to mark endpoints as public, it is in line with the implementation of
otelhttp.