Skip to content

add option for public endpoint to gRPC#7407

Merged
dmathieu merged 7 commits intoopen-telemetry:mainfrom
jan-xyz:add-public-endpoint-option-grpc
Jun 5, 2025
Merged

add option for public endpoint to gRPC#7407
dmathieu merged 7 commits intoopen-telemetry:mainfrom
jan-xyz:add-public-endpoint-option-grpc

Conversation

@jan-xyz
Copy link
Copy Markdown
Contributor

@jan-xyz jan-xyz commented May 30, 2025

Related: #7406

This adds the option to mark endpoints as public, it is in line with the implementation of otelhttp.

@jan-xyz jan-xyz requested review from a team and dashpole as code owners May 30, 2025 11:57
Copy link
Copy Markdown
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Just needs unit tests for config and for the handler

@jan-xyz
Copy link
Copy Markdown
Contributor Author

jan-xyz commented May 30, 2025

hey, thank you for the fast response. I added tests, I based them on the otelhttp tests again to keep them both close. There were no existing tests for this part of the code so I hope this works.

@jan-xyz jan-xyz force-pushed the add-public-endpoint-option-grpc branch from 5c47ffa to 4e191c3 Compare May 30, 2025 15:18
@jan-xyz jan-xyz requested a review from dashpole May 30, 2025 15:18
@jan-xyz jan-xyz force-pushed the add-public-endpoint-option-grpc branch from 4e191c3 to 382c644 Compare June 2, 2025 07:40
Comment thread CHANGELOG.md Outdated
@jan-xyz jan-xyz force-pushed the add-public-endpoint-option-grpc branch from 644d5c4 to f16cccf Compare June 2, 2025 07:45
@jan-xyz jan-xyz requested a review from dmathieu June 2, 2025 07:45
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.3%. Comparing base (64d8e65) to head (69593bc).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #7407   +/-   ##
=====================================
  Coverage   82.2%   82.3%           
=====================================
  Files        205     205           
  Lines      17949   17967   +18     
=====================================
+ Hits       14768   14795   +27     
+ Misses      2743    2735    -8     
+ Partials     438     437    -1     
Files with missing lines Coverage Δ
...entation/google.golang.org/grpc/otelgrpc/config.go 92.0% <100.0%> (+10.4%) ⬆️
...n/google.golang.org/grpc/otelgrpc/stats_handler.go 98.7% <100.0%> (+<0.1%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread instrumentation/google.golang.org/grpc/otelgrpc/stats_handler_test.go Outdated
@jan-xyz jan-xyz requested a review from dmathieu June 2, 2025 08:35
@jan-xyz jan-xyz force-pushed the add-public-endpoint-option-grpc branch from 6704b75 to bafe9f4 Compare June 2, 2025 09:28
@dmathieu
Copy link
Copy Markdown
Member

dmathieu commented Jun 2, 2025

Please don't rebase your branch every time. Merge commits make our reviews much easier.

@jan-xyz
Copy link
Copy Markdown
Contributor Author

jan-xyz commented Jun 5, 2025

sorry for the many rebases, I only wanted to fix the merge conflict with main. I hope I didn't complicate things for the PR?

@dmathieu dmathieu merged commit a2d546b into open-telemetry:main Jun 5, 2025
27 checks passed
@jan-xyz jan-xyz deleted the add-public-endpoint-option-grpc branch June 5, 2025 17:03
@MrAlias MrAlias added this to the v1.37.0 milestone Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants