Upgrade semconv to 1.32.0 for otelmongo#7393
Conversation
5fbe2ad to
55b0582
Compare
e220d0b to
ff66293
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7393 +/- ##
=====================================
Coverage 82.4% 82.4%
=====================================
Files 205 205
Lines 18084 18084
=====================================
Hits 14906 14906
Misses 2741 2741
Partials 437 437
🚀 New features to boost your workflow:
|
prestonvasquez
left a comment
There was a problem hiding this comment.
@MrAlias The doc.go file should be updated to reflect this update:
// The "OTEL_SEMCONV_STABILITY_OPT_IN" environment variable can be used to opt
// into the latest semantic version:
// - "database": emit latest semantic conventions
// - "": emit v1.21.0 (default) semantic conventions
// - "database/dup": emit v1.21.0 (default) and latest
//
// By default, otelmongo only emits v1.21.0.
It might also be helpful to list what the latest semantic version is.
|
Keeping the term "latest" prevents constant manual intervention and the inevitability of becoming out of sync. I prefer to keep the terms as they are. Users with the desire for details on what version of semantic convention they are emitting can look at the produced telemetry scheme URL or the code they are reading this from . |
@MrAlias I specifically added the word "latest" so you could just drop the update in. The current doc.go files specifies 1.26.0. |
Ah, gotcha. I misunderstood. Sounds like we are in favor of the same result. |
No description provided.