Skip to content

Upgrade semconv to 1.32.0 for otelmongo#7393

Merged
pellared merged 9 commits intoopen-telemetry:mainfrom
MrAlias:semconv-v1.32.0-otelmongo
Jun 2, 2025
Merged

Upgrade semconv to 1.32.0 for otelmongo#7393
pellared merged 9 commits intoopen-telemetry:mainfrom
MrAlias:semconv-v1.32.0-otelmongo

Conversation

@MrAlias
Copy link
Copy Markdown
Contributor

@MrAlias MrAlias commented May 28, 2025

No description provided.

@MrAlias MrAlias added this to the v1.37.0 milestone May 28, 2025
@github-actions github-actions Bot requested a review from prestonvasquez May 28, 2025 21:11
@MrAlias MrAlias force-pushed the semconv-v1.32.0-otelmongo branch from 5fbe2ad to 55b0582 Compare May 28, 2025 21:14
@MrAlias MrAlias force-pushed the semconv-v1.32.0-otelmongo branch from e220d0b to ff66293 Compare May 29, 2025 00:18
@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.4%. Comparing base (15cb04e) to head (9d9177b).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #7393   +/-   ##
=====================================
  Coverage   82.4%   82.4%           
=====================================
  Files        205     205           
  Lines      18084   18084           
=====================================
  Hits       14906   14906           
  Misses      2741    2741           
  Partials     437     437           
Files with missing lines Coverage Δ
.../mongo/otelmongo/internal/semconv/event_monitor.go 100.0% <100.0%> (ø)
...ngodb.org/mongo-driver/v2/mongo/otelmongo/mongo.go 88.5% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MrAlias MrAlias marked this pull request as ready for review May 29, 2025 14:26
@MrAlias MrAlias requested a review from a team as a code owner May 29, 2025 14:26
Copy link
Copy Markdown
Member

@prestonvasquez prestonvasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MrAlias The doc.go file should be updated to reflect this update:

// The "OTEL_SEMCONV_STABILITY_OPT_IN" environment variable can be used to opt
// into the latest semantic version:
//   - "database": emit latest semantic conventions
//   - "": emit v1.21.0 (default) semantic conventions
//   - "database/dup": emit v1.21.0 (default) and latest
//
// By default, otelmongo only emits v1.21.0.

It might also be helpful to list what the latest semantic version is.

@MrAlias
Copy link
Copy Markdown
Contributor Author

MrAlias commented May 30, 2025

Keeping the term "latest" prevents constant manual intervention and the inevitability of becoming out of sync. I prefer to keep the terms as they are.

Users with the desire for details on what version of semantic convention they are emitting can look at the produced telemetry scheme URL or the code they are reading this from .

@prestonvasquez
Copy link
Copy Markdown
Member

Keeping the term "latest" prevents constant manual intervention and the inevitability of becoming out of sync. I prefer to keep the terms as they are.

Users with the desire for details on what version of semantic convention they are emitting can look at the produced telemetry scheme URL or the code they are reading this from .

@MrAlias I specifically added the word "latest" so you could just drop the update in. The current doc.go files specifies 1.26.0.

@MrAlias
Copy link
Copy Markdown
Contributor Author

MrAlias commented May 30, 2025

Keeping the term "latest" prevents constant manual intervention and the inevitability of becoming out of sync. I prefer to keep the terms as they are.
Users with the desire for details on what version of semantic convention they are emitting can look at the produced telemetry scheme URL or the code they are reading this from .

@MrAlias I specifically added the word "latest" so you could just drop the update in. The current doc.go files specifies 1.26.0.

Ah, gotcha. I misunderstood. Sounds like we are in favor of the same result.

@pellared pellared merged commit 99703a7 into open-telemetry:main Jun 2, 2025
27 checks passed
@MrAlias MrAlias deleted the semconv-v1.32.0-otelmongo branch June 16, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants