Skip to content

Upgrade semconv to v1.32.0 in host instrumentation#7390

Merged
pellared merged 14 commits intoopen-telemetry:mainfrom
MrAlias:semconv-v1.32.0-host
Jun 2, 2025
Merged

Upgrade semconv to v1.32.0 in host instrumentation#7390
pellared merged 14 commits intoopen-telemetry:mainfrom
MrAlias:semconv-v1.32.0-host

Conversation

@MrAlias
Copy link
Copy Markdown
Contributor

@MrAlias MrAlias commented May 28, 2025

Add integration test to validate what is changing.

Resolve #2755

@MrAlias MrAlias added this to the v1.37.0 milestone May 28, 2025
@github-actions github-actions Bot requested a review from dmathieu May 28, 2025 19:20
@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2025

Codecov Report

Attention: Patch coverage is 93.50649% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.4%. Comparing base (2f88731) to head (2b46256).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
instrumentation/host/host.go 93.5% 0 Missing and 5 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #7390     +/-   ##
=======================================
+ Coverage   81.5%   82.4%   +0.8%     
=======================================
  Files        205     205             
  Lines      18075   18085     +10     
=======================================
+ Hits       14747   14904    +157     
+ Misses      2906    2743    -163     
- Partials     422     438     +16     
Files with missing lines Coverage Δ
instrumentation/host/example/main.go 0.0% <ø> (ø)
instrumentation/host/host.go 76.5% <93.5%> (+76.5%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MrAlias MrAlias marked this pull request as ready for review May 28, 2025 20:42
@MrAlias MrAlias requested a review from a team as a code owner May 28, 2025 20:42
Copy link
Copy Markdown
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nit suggestions. Nice work.

Comment thread instrumentation/host/host_test.go Outdated
Comment thread instrumentation/host/host_test.go Outdated
Comment thread instrumentation/host/host_test.go Outdated
@pellared pellared merged commit 23734b6 into open-telemetry:main Jun 2, 2025
27 checks passed
@MrAlias MrAlias deleted the semconv-v1.32.0-host branch June 16, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add integration testing to the host instrumenation

3 participants