Skip to content

Upgrade semconv to 1.32.0 for HTTP packages#7383

Merged
pellared merged 9 commits intoopen-telemetry:mainfrom
MrAlias:semconv-1.32.0-http
Jun 2, 2025
Merged

Upgrade semconv to 1.32.0 for HTTP packages#7383
pellared merged 9 commits intoopen-telemetry:mainfrom
MrAlias:semconv-1.32.0-http

Conversation

@MrAlias
Copy link
Copy Markdown
Contributor

@MrAlias MrAlias commented May 28, 2025

  • Remove TestHTTPServerDoesNotPanic/emtpy and TestHTTPClientDoesNotPanic/empty. We control all uses of this type.
  • Updates otelrestful, otelgin, otelmux, otelhttptrace, and otelhttp.

@MrAlias MrAlias added this to the v1.37.0 milestone May 28, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.2%. Comparing base (99703a7) to head (9b90be2).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #7383     +/-   ##
=======================================
- Coverage   82.4%   82.2%   -0.2%     
=======================================
  Files        205     205             
  Lines      18084   17949    -135     
=======================================
- Hits       14903   14762    -141     
- Misses      2743    2749      +6     
  Partials     438     438             
Files with missing lines Coverage Δ
...lei/go-restful/otelrestful/internal/semconv/env.go 95.5% <100.0%> (+0.5%) ⬆️
...o-restful/otelrestful/internal/semconv/httpconv.go 87.5% <ø> (-1.5%) ⬇️
...ei/go-restful/otelrestful/internal/semconv/util.go 82.8% <ø> (ø)
....com/gin-gonic/gin/otelgin/internal/semconv/env.go 95.5% <100.0%> (+0.5%) ⬆️
...gin-gonic/gin/otelgin/internal/semconv/httpconv.go 89.1% <ø> (-1.3%) ⬇️
...com/gin-gonic/gin/otelgin/internal/semconv/util.go 82.8% <ø> (ø)
...ub.com/gorilla/mux/otelmux/internal/semconv/env.go 93.8% <100.0%> (+0.8%) ⬆️
...m/gorilla/mux/otelmux/internal/semconv/httpconv.go 87.5% <ø> (-1.5%) ⬇️
...b.com/gorilla/mux/otelmux/internal/semconv/util.go 82.8% <ø> (ø)
...tp/httptrace/otelhttptrace/internal/semconv/env.go 91.6% <100.0%> (+1.1%) ⬆️
... and 5 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MrAlias MrAlias force-pushed the semconv-1.32.0-http branch from 2d6864a to fa26f62 Compare May 28, 2025 18:05
@MrAlias MrAlias marked this pull request as ready for review May 28, 2025 18:19
@MrAlias MrAlias requested a review from a team as a code owner May 28, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants