Skip to content

otelzap: refactor Core tests#7380

Merged
pellared merged 8 commits into
open-telemetry:mainfrom
pellared:refactor-zap-test
Jun 2, 2025
Merged

otelzap: refactor Core tests#7380
pellared merged 8 commits into
open-telemetry:mainfrom
pellared:refactor-zap-test

Conversation

@pellared
Copy link
Copy Markdown
Member

@pellared pellared commented May 28, 2025

Use the new convenience of https://pkg.go.dev/go.opentelemetry.io/otel/log/logtest.

The tests should be more readable and the assertions are more precise.
They also give better assertion messages on failures (diff).

@pellared pellared requested a review from a team as a code owner May 28, 2025 15:43
@github-actions github-actions Bot requested a review from khushijain21 May 28, 2025 15:43
@pellared pellared added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label May 28, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.4%. Comparing base (47c05d8) to head (1aee923).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #7380     +/-   ##
=======================================
- Coverage   82.4%   82.4%   -0.1%     
=======================================
  Files        205     205             
  Lines      18085   18085             
=======================================
- Hits       14907   14904      -3     
- Misses      2741    2743      +2     
- Partials     437     438      +1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pellared pellared added the bridge: zap Related to the zap bridge label May 28, 2025
@khushijain21
Copy link
Copy Markdown
Contributor

This looks great!

@pellared pellared merged commit 80afd76 into open-telemetry:main Jun 2, 2025
40 of 44 checks passed
@pellared pellared deleted the refactor-zap-test branch June 2, 2025 18:18
@MrAlias MrAlias added this to the v1.37.0 milestone Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bridge: zap Related to the zap bridge Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants