Skip to content

Removed deprecated StreamServerInterceptor function from otelgrpc#7362

Merged
MrAlias merged 11 commits intoopen-telemetry:mainfrom
sonalgaud12:remove-func
May 28, 2025
Merged

Removed deprecated StreamServerInterceptor function from otelgrpc#7362
MrAlias merged 11 commits intoopen-telemetry:mainfrom
sonalgaud12:remove-func

Conversation

@sonalgaud12
Copy link
Copy Markdown
Contributor

@sonalgaud12 sonalgaud12 commented May 24, 2025

This PR addresses #7107

  • Removed the deprecated StreamServerInterceptor function
  • Removed the benchmark test
  • Removed tests
  • Added a changelog entry in the ### Removed section of the unreleased changelog for the removal this as checkbox for md

@sonalgaud12 sonalgaud12 requested review from a team and dashpole as code owners May 24, 2025 08:40
@codecov
Copy link
Copy Markdown

codecov Bot commented May 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.5%. Comparing base (2f0a9c7) to head (3aa22bd).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #7362     +/-   ##
=======================================
- Coverage   81.6%   81.5%   -0.1%     
=======================================
  Files        205     205             
  Lines      18187   18107     -80     
=======================================
- Hits       14841   14760     -81     
- Misses      2924    2925      +1     
  Partials     422     422             
Files with missing lines Coverage Δ
...ion/google.golang.org/grpc/otelgrpc/interceptor.go 79.4% <100.0%> (-7.8%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread CHANGELOG.md Outdated
Comment thread instrumentation/google.golang.org/grpc/otelgrpc/interceptor.go Outdated
@sonalgaud12 sonalgaud12 requested a review from MrAlias May 25, 2025 08:12
Comment thread CHANGELOG.md Outdated
@sonalgaud12 sonalgaud12 requested a review from MrAlias May 28, 2025 11:16
@dmathieu dmathieu changed the title Removed deprecated func Removed deprecated StreamServerInterceptor function from otelgrpc May 28, 2025
@MrAlias MrAlias merged commit d6c8344 into open-telemetry:main May 28, 2025
28 checks passed
@sonalgaud12 sonalgaud12 deleted the remove-func branch May 29, 2025 07:21
@MrAlias MrAlias added this to the v1.37.0 milestone Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants