Skip to content

propagators/aws/xray: sample only when Sampled=1#7318

Merged
MrAlias merged 4 commits intoopen-telemetry:mainfrom
seankhliao:fix-sample
May 13, 2025
Merged

propagators/aws/xray: sample only when Sampled=1#7318
MrAlias merged 4 commits intoopen-telemetry:mainfrom
seankhliao:fix-sample

Conversation

@seankhliao
Copy link
Copy Markdown
Contributor

Fixes #7262

@seankhliao seankhliao requested a review from a team as a code owner May 12, 2025 17:58
@github-actions github-actions Bot requested a review from akats7 May 12, 2025 17:58
Comment thread propagators/aws/xray/propagator.go
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.2%. Comparing base (71a2939) to head (cec7555).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
propagators/aws/xray/propagator.go 80.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #7318   +/-   ##
=====================================
  Coverage   81.2%   81.2%           
=====================================
  Files        207     207           
  Lines      18270   18271    +1     
=====================================
+ Hits       14839   14843    +4     
+ Misses      3009    3007    -2     
+ Partials     422     421    -1     
Files with missing lines Coverage Δ
propagators/aws/xray/propagator.go 77.0% <80.0%> (+0.2%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread CHANGELOG.md Outdated
Comment thread propagators/aws/xray/propagator.go
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Comment thread CHANGELOG.md Outdated
seankhliao and others added 2 commits May 13, 2025 09:02
Co-authored-by: Damien Mathieu <42@dmathieu.com>
@MrAlias MrAlias merged commit 9ad79c8 into open-telemetry:main May 13, 2025
26 of 29 checks passed
@MrAlias MrAlias added this to the v1.36.0 milestone May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

parseTraceFlag erroneously marks non‑“1” values as sampled, causing over‑sampling

3 participants