otelgin: add http.route metric attribute#7275
Merged
dmathieu merged 3 commits intoopen-telemetry:mainfrom Apr 29, 2025
Merged
Conversation
Member
|
Can you add some unit tests? |
Member
Contributor
Author
|
sure, will do |
5c09f8d to
4a426ee
Compare
Contributor
Author
|
updated unit test and changelog |
flc1125
requested changes
Apr 27, 2025
4a426ee to
758ef4c
Compare
MrAlias
reviewed
Apr 27, 2025
758ef4c to
8374c20
Compare
flc1125
requested changes
Apr 28, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7275 +/- ##
=======================================
- Coverage 81.1% 81.1% -0.1%
=======================================
Files 204 204
Lines 18148 18151 +3
=======================================
Hits 14728 14728
- Misses 3001 3003 +2
- Partials 419 420 +1
🚀 New features to boost your workflow:
|
flc1125
approved these changes
Apr 28, 2025
8374c20 to
8736109
Compare
dmathieu
reviewed
Apr 29, 2025
8736109 to
793a005
Compare
Contributor
Author
|
Hi, @dmathieu, thanks for your comments, I've updated code and resolved them. |
dmathieu
approved these changes
Apr 29, 2025
Member
|
Note: you should avoid force-pushing your branch. It makes reviews much easier. |
Contributor
Author
|
@dmathieu Got it. I thought I should alway only keep one commit for the PR. |
Member
|
No. GitHub will squash once we merge the PR. |
Contributor
Author
|
That's cool. I'll keep in mind :-) |
pellared
approved these changes
Apr 29, 2025
Co-authored-by: Robert Pająk <pellared@hotmail.com>
akats7
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the Semantic conventions for HTTP metrics | OpenTelemetry,
http.routeis a stable label for http server metrics, I suggest to set it as a default label in the gin middleware.