otelgin: Add a WithSpanStartOptions option#7261
otelgin: Add a WithSpanStartOptions option#7261dmathieu merged 3 commits intoopen-telemetry:mainfrom arshukla98:Issue_7247
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7261 +/- ##
=======================================
- Coverage 81.2% 81.2% -0.1%
=======================================
Files 207 207
Lines 18263 18270 +7
=======================================
+ Hits 14835 14839 +4
- Misses 3007 3009 +2
- Partials 421 422 +1
🚀 New features to boost your workflow:
|
dmathieu
left a comment
There was a problem hiding this comment.
This is missing tests and a changelog entry.
| cfg := config{} | ||
|
|
||
| defaultOpts := []Option{ | ||
| WithSpanOptions(oteltrace.WithSpanKind(oteltrace.SpanKindServer)), |
There was a problem hiding this comment.
What is the reason for moving this part here?
There was a problem hiding this comment.
This structure is also used in otelhttp, as seen [here](
opentelemetry-go-contrib/instrumentation/net/http/otelhttp/handler.go
Lines 52 to 60 in f368d04
Let me know if you’d prefer to remove it.
There was a problem hiding this comment.
According to the principle of Occam's Razor: Do not multiply entities beyond necessity.
From what I understand, the operating result would be the same even without modifying this part.
|
Additionally, please correct the title of this PR. |
flc1125
left a comment
There was a problem hiding this comment.
If you are ready for review, you can remove the draft mode.
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Closes: #7247